Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an ipfs worker message #40

Merged
merged 2 commits into from
Oct 4, 2022
Merged

add an ipfs worker message #40

merged 2 commits into from
Oct 4, 2022

Conversation

il3ven
Copy link
Contributor

@il3ven il3ven commented Sep 26, 2022

Fixes #35. The message expects a native IPFS URL e.g. ipfs://Qmeb.... The actual CID checking will be done in extraction worker using the multiformats library.

src/schema.mjs Outdated Show resolved Hide resolved
src/schema.mjs Outdated Show resolved Hide resolved
test/schema_test.mjs Outdated Show resolved Hide resolved
test/schema_test.mjs Outdated Show resolved Hide resolved
src/schema.mjs Outdated Show resolved Hide resolved
Copy link
Collaborator

@TimDaub TimDaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@TimDaub
Copy link
Collaborator

TimDaub commented Oct 4, 2022

the ipfs message schema must be a prototype for an arweave message schema

@TimDaub TimDaub self-assigned this Oct 4, 2022
@TimDaub
Copy link
Collaborator

TimDaub commented Oct 4, 2022

I'll take over

il3ven added a commit to neume-network/extraction-worker that referenced this pull request Oct 4, 2022
The CI will still not pass because we need to merge
neume-network/schema#40 first.
@TimDaub TimDaub merged commit 4480087 into main Oct 4, 2022
@il3ven il3ven deleted the 11/ipfs branch October 4, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add an ipfs message extractor message that requires a valid CID
2 participants